Nl #426

puneith · 2016-07-20T21:18:10Z

@jerjou @waprin please review.

Change-Id: I089b244f1a0a2210fffab6f5747eed9f6150147a

Change-Id: I8ff59d08f2ae8ce4cb3dd0b57b3548db3d5b8add

Change-Id: I1367429c3ceaefd0b0d36d9d7cad6ca29cbfdd2d

Change-Id: Iecc1327db4aa21eb5ee61ce58bba3d142e600734

Change-Id: I33a6c3259dc5a9b0cc1ad081cd57acc452fc6b1a

Change-Id: Ic2b721f775601d2dfb718be26d425e7c2e91eb8a

Change-Id: I2eac2d41e3f8d96c1d049dbbc7b48c96d5fded0a

Change-Id: I026963be93ca3ef776420807e14abdcfcc5fe95f

Change-Id: Iab58378f40c760e88f2b3cc0806985894ce77e76

This reverts commit 0be30eb.

Change-Id: Ib2f1a2b04c0d00cd62d178d92430379b64ea9781

Change-Id: Iea8672b60bd6ebe9602378bb8b2622a44b48e608

…es into nl

waprin · 2016-07-20T21:25:30Z

language/movie_nl/main.py

+    items.sort(reverse=True)
+    items = [json.dumps(item[1]) for item in items]
+
+    if reverse_bool:


sorry if I'm misunderstanding this, but it looks like you are reversing then condtionally reverse again. any way to write to just conditionally reverse once?

jerjou · 2016-07-20T22:05:43Z

language/movie_nl/main.py

+
+    try:
+        sentiments = [get_sentiment(service, sentence) for sentence in sentences]
+    except HttpError as e:


This try/catch is unnecessary.

waprin · 2016-07-21T20:49:36Z

LGTM

waprin · 2016-07-21T21:19:02Z

Given Traivs passes I'm sure it's fine but is this a nox issue?

import file mismatch:
imported module 'main_test' has this __file__ attribute:
  /Users/waprin/code/python-docs-samples/language/movie_nl/main_test.py
which is not the same as the test file we want to collect:
  /Users/waprin/code/python-docs-samples/language/ocr_nl/main_test.py

waprin · 2016-07-21T21:19:20Z

That's when I just run

nox --session tests -- language/

puneith · 2016-07-21T21:37:21Z

So when I do nox it is successful. I see there is movie_nl and ocr_nl in your output above? Is this something with ocr? Donno?

waprin · 2016-07-21T21:38:18Z

Are you doing just nox or the command I ran that just does the language directory? It passes on Travis so likely an issue on my laptop ,just mentioning here....

puneith · 2016-07-21T22:01:11Z

@waprin I had to update the README and also get rid of the FileType for the rank feature.

waprin · 2016-07-21T22:08:46Z

alright i just ran commands again and worked for me. meeeerge away

waprin · 2016-07-21T22:09:22Z

I still have that test issue but again pretty sure it's nox related. out of curiosity can you try that? nox --session tests -- language

theacodes · 2016-07-21T22:14:46Z

You need to specify the individual sample -- language/movie_nl

On Thu, Jul 21, 2016, 3:09 PM Bill Prin notifications@github.com wrote:

I still have that test issue but again pretty sure it's nox related. out
of curiosity can you try that? nox --session tests -- language

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#426 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUcxToC4BolGGqTVBEU94FUiM8FctDks5qX-4TgaJpZM4JRN78
.

jerjou · 2016-07-21T22:59:56Z

Next time you merge, can you please squash your commits?

theacodes · 2016-07-21T23:01:33Z

Please let Jerjou, Bill, or Myself merge in the future, just for consistency. I'm going to manually squash these commits.

* chore(deps): update dependency google-cloud-storage to v2.7.0 * docs(samples): removed batch_process_documents_sample_bad_input_test Co-authored-by: Renovate Bot <bot@renovateapp.com>

Jerjou Cheng and others added 15 commits July 19, 2016 18:27

Add samples for natural language api.

5fb9def

Change-Id: I089b244f1a0a2210fffab6f5747eed9f6150147a

fixed variable name error

aff93ad

logged error message with exception

03cb67b

Change-Id: I8ff59d08f2ae8ce4cb3dd0b57b3548db3d5b8add

fixed variable unused error

e2cc3d5

Change-Id: I1367429c3ceaefd0b0d36d9d7cad6ca29cbfdd2d

Refactor for clarity.

1789677

Change-Id: Iecc1327db4aa21eb5ee61ce58bba3d142e600734

cast samples to int

1242524

Change-Id: I33a6c3259dc5a9b0cc1ad081cd57acc452fc6b1a

added sample variable

3e4deb1

Change-Id: Ic2b721f775601d2dfb718be26d425e7c2e91eb8a

fixed indentation bug

4ffc546

Change-Id: I2eac2d41e3f8d96c1d049dbbc7b48c96d5fded0a

Fix lint errors

7ca9918

Change-Id: I026963be93ca3ef776420807e14abdcfcc5fe95f

Remove movie_nl sample until it's more stable.

0be30eb

Change-Id: Iab58378f40c760e88f2b3cc0806985894ce77e76

Revert "Remove movie_nl sample until it's more stable."

47c7c63

This reverts commit 0be30eb.

catch HttpError and log it

0a8d040

Change-Id: Ib2f1a2b04c0d00cd62d178d92430379b64ea9781

added retry in the request

8076a63

Change-Id: Iea8672b60bd6ebe9602378bb8b2622a44b48e608

Merge branch 'nl' of github.com:GoogleCloudPlatform/python-docs-sampl…

f39bd6e

…es into nl

resolved README conflicts

c9ac6d3

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2016

theacodes added In Progress and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 20, 2016

waprin reviewed Jul 20, 2016
View reviewed changes

removed reverse bool

d465566

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2016

jerjou reviewed Jul 20, 2016
View reviewed changes

puneithk added 2 commits July 21, 2016 14:59

updated README.md to work due to wrong input name

9c610f0

removed FileType from argsparse

ae433ee

puneith merged commit df0153e into master Jul 21, 2016

theacodes removed the In Progress label Jul 21, 2016

theacodes deleted the nl branch July 21, 2016 23:01

theacodes restored the nl branch July 21, 2016 23:10

theacodes deleted the nl branch July 21, 2016 23:17

msampathkumar pushed a commit that referenced this pull request Nov 14, 2022

chore(deps): update dependency pytest to v7.1.3 (#426)

11d4f37

msampathkumar mentioned this pull request Nov 14, 2022

migrate code from googleapis/python-datacatalog #8508

Merged

8 tasks

holtskinner mentioned this pull request Jan 4, 2023

migrate code from googleapis/python-documentai #8862

Merged

8 tasks

Sita04 mentioned this pull request Feb 7, 2023

migrate code from googleapis/python-dlp #9091

Merged

8 tasks

Sita04 pushed a commit that referenced this pull request Feb 7, 2023

chore(deps): update all dependencies (#426)

459ba2c

dizcology pushed a commit that referenced this pull request Jun 16, 2023

chore(deps): update dependency google-cloud-bigquery to v3.4.2 (#426)

7eff80c

dizcology mentioned this pull request Jun 16, 2023

migrate code from googleapis/python-bigquery-datatransfer #10259

Merged

9 tasks

dizcology pushed a commit that referenced this pull request Jul 10, 2023

chore(deps): update dependency google-cloud-bigquery to v3.4.2 (#426)

9361eb7

leahecole pushed a commit that referenced this pull request Jul 11, 2023

chore(deps): update dependency google-cloud-bigquery to v3.4.2 (#426)

af20d70

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nl #426

Nl #426

puneith commented Jul 20, 2016

waprin Jul 20, 2016

jerjou Jul 20, 2016

waprin commented Jul 21, 2016

waprin commented Jul 21, 2016

waprin commented Jul 21, 2016

puneith commented Jul 21, 2016

waprin commented Jul 21, 2016

puneith commented Jul 21, 2016

waprin commented Jul 21, 2016

waprin commented Jul 21, 2016

theacodes commented Jul 21, 2016

jerjou commented Jul 21, 2016

theacodes commented Jul 21, 2016

Nl #426

Nl #426

Conversation

puneith commented Jul 20, 2016

waprin Jul 20, 2016

Choose a reason for hiding this comment

jerjou Jul 20, 2016

Choose a reason for hiding this comment

waprin commented Jul 21, 2016

waprin commented Jul 21, 2016

waprin commented Jul 21, 2016

puneith commented Jul 21, 2016

waprin commented Jul 21, 2016

puneith commented Jul 21, 2016

waprin commented Jul 21, 2016

waprin commented Jul 21, 2016

theacodes commented Jul 21, 2016

jerjou commented Jul 21, 2016

theacodes commented Jul 21, 2016